Add automatic support for Uniswap V3
complete
T
Thin Quail
Hi Petur,
I thik it's not 100% correct because the claimed rewards have 0 as gain instead of the MV.
Kr
S
https://app.koinly.io/p/transactions?id=D68F84184B694E044F05DD4AB6482185
P
Petur
Thin Quail:
Reward transactions are a type of income, so they will never have any gains associated with them when they are received. Instead, they will be included in your total income in your reports.
T
Thin Quail
Petur: thx for clearing this up for me. BTW do you have a similar solotion coming for kyberswap LP, I think they also use NFTs and its currently a mess in my tax report. Or maybe you can point me towards a workaround.
P
Petur
complete
Uniswap V3 liquidity transactions are now finally fully supported on ETH, MATIC, Optimism, and Arbitrum. We will be adding other chains as well but please create a new Canny ticket for this as it helps us prioritize the work :)
Some notes to be aware of:
- The new Uniswap logic will not apply automatically to any transactions that have been synced in the past. If you have already fixed those transactions manually then you don't need to do anything but if you want the new feature to handle any past transactions then you can either delete and recreate the affected wallet or do the following:
- Permanently delete all transactions related to UniV3 liquidity
- Resync the wallet from the beginning
(see more here: https://support.koinly.io/hc/en-us/articles/9917923407004-How-to-re-import-tokens-after-an-update)
This will resync the transactions and Koinly will then apply the new UniV3 logic when importing the transactions.
All newly synced UniV3 liquidity transactions will be handled automatically going forward :)
As always, please let us know if you encounter any issues or discover any errors/oversights!
T
Tremendous Mole
Petur: Hi, I have just tried to reimport all transactions. Some were correctly handed as Uniswap LP transactions, but some look like they were imported as normal withdrawals. Is there any way to tag them as Uniswap liquidity in?
P
Petur
Tremendous Mole: Would it be possible for you to share a link to this transaction on the explorer, or a transaction hash?
The only case we know of where this could happen, is if the token you are dealing with has no pricing data.
T
Tremendous Mole
Petur: These for example:
{}
There are many more. This one seems one that was correctly imported:
{}
But maybe something went wrong with my wallets? Because the wallet page is saying that the "API does not allow access to: Uniswap v3 liquidity." Even though I deleted the old wallet, some transactions (like permanently deleted ones) look like they were there from the previous wallet. Some of those that have the new LP Uniswap are tagged as csv.
F
Familiar Dove
Petur: Hi Peter.. where do we post bug reports? It detects Liquidity In and Liquidity Out for some of the entries, but others don't work and are detected as normal "Send" transactions. I deleted my wallet, and did a full import. Some detect, some don't. I think maybe because when you do liquidity with Uniswap V3 the transactions don't always follow the same pattern - so maybe there is an edge case that has not been handled yet.
P
Petur
Familiar Dove:
Hi JMP,
This thread is the best place to report any issues but you can also create a new Canny ticket if you prefer.
Would you be able to share a transaction hash (or explorer link) to one of the transactions that is not working? We should be able to address all issues quite quickly
P
Petur
Tremendous Mole:
Thank you for the details!
I've had a look and created a ticket for the developer. It should be fixed quite soon but I'll let you know :)
P
Petur
Tremendous Mole Familiar Dove
The issues discovered earlier have been fixed!
You can try clicking on 'Restart gains' in your settings to see if the transactions now get processed correctly. Please let me know if they don't
F
Familiar Dove
Petur: most of them autodetect now, but there are still others with issues (2 that i've found). 1. I've attached an image of a scenario that does not detect. It properly detects liquidity in of the two tokens, but because one of the tokens went to 0 during the interval, when you pull the liquidity it does not detect it as liquidity out. only one token comes out in the transaction because the other token has gone to 0 in the pool. koinly detects incorrectly as an exchange. 2. the opposite scenario also does not detect correctly, when you place the liquidity and you provide 0 of one of the coins, koinly detects it as an exchange instead of liquidity in.
P
Petur
Familiar Dove:
Hi JMP,
Yes, this is a known thing actually. Koinly's 'Liquidity' labels will only be applied when there are two assets coming or leaving the pool. When there is only one asset, it will just show as an exchange.
We're looking at improving this now but it doesn't have much of an effect, since these transactions are taxed the same way (ie. it's just useful for filtering really)
Z
Zinc white Chameleon
Petur: thanks a lot to all of you! I have tested it on arb and am very happy with the result.
100% regonition and the Single value exchange for lp token is actually how I manually dealt with this as well eg when zapping for v2 in the past. The nft no value deposit is a bit annoying but I guess we need it as uniswap is indeed spamming all of us with this nfts... Lol
Do you have plans to bring it to pancakeswap v3 on bcs chain? (it's using uniswap v3 code as well). Unfortunately that's where my main focus lies.
Cheers
M
Magenta Horse
Petur: I want to delete the individual transactions manually and re-sync (deleting the wallet would be painful given the amount of work done already on corrections), however I wonder if there is a way to search by contract?
I.e. 0xc36442b4a4522e871399cd717abdd847ab11fe88 is the Uniswap V3 contract given as Interacted With (To) in Koinly.
Ideally I want to surface just all the interactions with UniV3 to Perm Delete and then re-sync those wallets. This would be quicker than scanning for all Send / Deposits and opening the Tx in Etherscan to check it's related to a UniV3 position.
P
Petur
Magenta Horse: There is an advanced filter called "TxSrc" and another one called "TxDest". You can create a filter for all transactions where TxDest or TxSrc is equal to this contract address, and that should show all of these transactions.
However, we did find that there are some transactions where the main UNIv3 contract is not the TxDest, so this may not catch all transactions.
You should also look for all UNIv3 NFTs that you have received and delete those
P
Petur
Zinc white Chameleon:
Yes, we are planning to add support for Pancake as well, but I don't have an ETA for that atm
M
Magenta Horse
Petur: Thanks for pointing out the NFTs as well.
That means that for every LP position you have to delete the Send Tx and also check Etherscan for the corresponding ERC-721 token ID to find and delete that too, before re-syncing.
Z
Zinc white Chameleon
Petur: Hello Petur, I found a bug if stable coins are involved (at least on arbitrum chain for example usdc/eth). He fails to see the reward of the stable coin, so he trades the portion of the LP back into the correct stable amount + its rewards. However posting screenshots without doxxing myself is something i would fuck up for sure. If you are interested please tell me how to send you a txhash. Probably you can reproduce it easily tho yourself, dunno.
regards
P
Petur
Zinc white Chameleon:
Hi Nope,
In order to check this, I would need a transaction hash or explorer link.
You can post it here in the comment (and I'll remove it as soon as I've seen it) or you can send it to support@koinly.io and say that it's for Petur :)
P
Physical Harrier
An idea: Add an entry in a transaction 'Sent to LP' that create a counterpart transaction with the appropriate field and requests which LP to use, verifies that the existing LP has the correct tokens and automatically align the amount of LP to the existing LP info
P
Physical Harrier
Can the manual LP get a longer description, for instance #25534 to identify the UNI-V3 position in the meatime?
F
Familiar Dove
Physical Harrier: it's been years since Koinly have responded to this feature request... may have luck pinging them through the support chat for them to give us all an update... i just want an update on progress.. like are they 50% of the way through? 90%? some sort of meaningful status update.
P
Physical Harrier
It is also very inconvenient to select these NFTs, the #xxx is not editable, so with my 50+ 24501, 24505, etc, I cannot partially filter and thus I cannot select anything beyond 25!
P
Physical Harrier
Could there be a method to
split entries
on all UNI-V3 NFT? I only noticed that creating a one-side entry seem to trigger Koinly to create an Exchange
entry. I think this is very bad as the tokens used must disappear from the accounting!Z
Zinc white Chameleon
No news since may 24... Guys in all honesty, can you imagine how important this is? :( I am really a fan of Koinly but if you cannot finish this then PLEASE tell us so that we have a chance to react in time.
F
Familiar Dove
Zinc white Chameleon: I am hanging out for this so that I can lodge my tax. It is very frustrating.
C
Citrine Chinchilla
+100 to this being pushed ASAP
F
Familiar Dove
is there an ETA of the Uniswap V3 support?
F
Familiar Dove
any update on this please? thanks.
Load More
→